Decklist and card viewer plugin

[U_Mage]

just saying in case you missed it somehow, this is built on nodebb and they have a plugin template here https://github.com/NodeBB/nodebb-plugin-quickstart

[komfyrion]

I picked up on that, yep.

[komfyrion]

@u_mage Here's the first version. Give it a try!
https://github.com/braaar/nodebb-plugin-fab-cards

[U_Mage]

Fyendal's Spring Tunic

[U_Mage]

ah, ok thought it was broken but it just fetches when the page loads, I envisioned it a bit different but it's working

[komfyrion]

My initial idea was to implement a server side functionality that would filter upon posting and insert HTML card embeds. I got it a rough draft of that working with a filter hook.
The problem was that I couldn't see a way to make it not look weird if you would try to edit a post that had cards embedded. Ideally I would have wanted another hook that would essentially strip away the card embeds when you hit edit, but I found no such hook. Could be it exists. The edit hooks that exist seem to apply once you click save in the editor? I would maybe like to ask about that. Maybe they could add a hook for this.

I was also worried that the embedded card markup in the actual post content would look awful if consumed outside of this site via federation. At least the embeds would have to be something that's not annoying to read on the other end, like a normal hyperlink. In that case I suppose the client side script in here could then only take care of inserting the images on hover, which would be a lot simpler and more performant.

[komfyrion]

Regardless, the CSS could use some tweaking. It's a bit janky in terms of where the image appears in the viewport, especially on mobile.

And support for specifying the colour of a card would be nice.

To Be Continued...

[komfyrion]

Oh my! I just found out how this can be done server side! We don't need a separate edit hook, we just use filter:parse.post

[Sawyer]

have to say the plugin is really sick, well done!

[komfyrion]

Thanks! 8char